Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for row_alias syntax added in MySQL 8.0.19. #15510

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Add support for row_alias syntax added in MySQL 8.0.19. #15510

merged 4 commits into from
Apr 4, 2024

Conversation

arthurschreiber
Copy link
Contributor

@arthurschreiber arthurschreiber commented Mar 18, 2024 •
edited by GuptaManan100
Loading

Description

This pull request adds support for the row_alias syntax added in MySQL 8.0.19 for INSERT INTO statements.

Related Issue(s)

#15509

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 18, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 18, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 18, 2024
@arthurschreiber arthurschreiber marked this pull request as ready for review March 18, 2024 10:41
@arthurschreiber
Copy link
Contributor Author

Unit tests are failing due to some whitespace changes I accidentally committed. Will fix that later.

@arthurschreiber arthurschreiber force-pushed the arthur/row-alias-syntax branch from 6440c7c to ebe5b70 Compare March 18, 2024 20:07
@arthurschreiber arthurschreiber changed the title [WIP] Add support for row_alias syntax added in MySQL 8.0.19. Add support for row_alias syntax added in MySQL 8.0.19. Mar 18, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 68.14%. Comparing base (557a9bd) to head (92ad7bc).
Report is 2 commits behind head on main.

Files Patch % Lines
go/vt/sqlparser/ast_format.go 58.33% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15510      +/-   ##
==========================================
+ Coverage   68.12%   68.14%   +0.01%     
==========================================
  Files        1556     1556              
  Lines      195019   195028       +9     
==========================================
+ Hits       132858   132903      +45     
+ Misses      62161    62125      -36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arthurschreiber
Copy link
Contributor Author

Looks like this increases the number of shift/reduce conflicts from 3 to 7? 🤔 I'm not quite sure why, if anyone could give me a few pointers on how to fix that, I'd be happy to take a stab at it.

@dbussink
Copy link
Contributor

Looks like this increases the number of shift/reduce conflicts from 3 to 7? 🤔 I'm not quite sure why, if anyone could give me a few pointers on how to fix that, I'd be happy to take a stab at it.

@GuptaManan100 is probably the subject matter expert on this topic.

@arthurschreiber
Copy link
Contributor Author

Okay, I think I understand where the conflicts are coming from.

The insert_data parsing rule used by insert_statement can either be a list of values, or can be a SELECT from a different table. if it's a SELECT, it can contain select_expression which contains as_ci_opt, which conflicts with the AS used by the row alias syntax.

The good thing here is that the row alias syntax can only be used with VALUES or SET. This seems fixable, but will require some refactoring of the parser.

I also noticed that the way insert_or_replace is used can lead to invalid syntax being accepted by the Vitess parser. For example, REPLACE can not be used together with ON DUPLICATE KEY UPDATE - but the parser allows this.

maxprokopiev added a commit to maxprokopiev/rails that referenced this pull request Mar 19, 2024
@maxprokopiev
Extract check for VALUES syntax
f384c1b 
The change to upserts (rails#51274) is causing
an issue with Vitess, since it doesn't support the `row_alias` syntax added
in MySQL 8.0.19.

There is an ongoing work (vitessio/vitess#15510)
to add that support and it is likely to be included into Vitess v20,
but in the meantime it would be nice to have an ability to control that
behavior in the existing apps.
@maxprokopiev maxprokopiev mentioned this pull request Mar 19, 2024
Merged
4 tasks
maxprokopiev added a commit to maxprokopiev/rails that referenced this pull request Mar 19, 2024
@maxprokopiev
Extract check for VALUES syntax
6a4fd54 
The change to upserts (rails#51274) is causing
an issue with Vitess, since it doesn't support the `row_alias` syntax added
in MySQL 8.0.19.

There is an ongoing work (vitessio/vitess#15510)
to add that support and it is likely to be included into Vitess v20,
but in the meantime it would be nice to have an ability to control that
behavior in the existing apps.
maxprokopiev added a commit to maxprokopiev/rails that referenced this pull request Mar 19, 2024
@maxprokopiev
Extract check for VALUES syntax
2433076 
The change to upserts (rails#51274) is causing
an issue with Vitess, since it doesn't support the `row_alias` syntax added
in MySQL 8.0.19.

There is an ongoing work (vitessio/vitess#15510)
to add that support and it is likely to be included into Vitess v20,
but in the meantime it would be nice to have an ability to control that
behavior in the existing apps.
@GuptaManan100
Copy link
Member

I'm looking into it

maxprokopiev added a commit to maxprokopiev/rails that referenced this pull request Mar 19, 2024
@maxprokopiev
Extract check for VALUES/row_alias syntax
6aec2ca 
The change to upserts (rails#51274) is causing
an issue with Vitess, since it doesn't support the `row_alias` syntax added
in MySQL 8.0.19.

There is an ongoing work (vitessio/vitess#15510)
to add that support and it is likely to be included into Vitess v20,
but in the meantime it would be nice to have an ability to control that
behavior in the existing apps.
viralpraxis pushed a commit to viralpraxis/rails that referenced this pull request Mar 24, 2024
@maxprokopiev @viralpraxis
Extract check for VALUES/row_alias syntax
a6d4f07 
The change to upserts (rails#51274) is causing
an issue with Vitess, since it doesn't support the `row_alias` syntax added
in MySQL 8.0.19.

There is an ongoing work (vitessio/vitess#15510)
to add that support and it is likely to be included into Vitess v20,
but in the meantime it would be nice to have an ability to control that
behavior in the existing apps.
@GuptaManan100 GuptaManan100 removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Apr 4, 2024
@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 4, 2024
@frouioui frouioui merged commit 97890a7 into main Apr 4, 2024
201 checks passed
@frouioui frouioui deleted the arthur/row-alias-syntax branch April 4, 2024 16:43
fractaledmind pushed a commit to fractaledmind/rails that referenced this pull request May 13, 2024
@maxprokopiev @fractaledmind
Extract check for VALUES/row_alias syntax
e529487 
The change to upserts (rails#51274) is causing
an issue with Vitess, since it doesn't support the `row_alias` syntax added
in MySQL 8.0.19.

There is an ongoing work (vitessio/vitess#15510)
to add that support and it is likely to be included into Vitess v20,
but in the meantime it would be nice to have an ability to control that
behavior in the existing apps.
xjunior pushed a commit to xjunior/rails that referenced this pull request Jun 9, 2024
@maxprokopiev @xjunior
Extract check for VALUES/row_alias syntax
e0e26bc 
The change to upserts (rails#51274) is causing
an issue with Vitess, since it doesn't support the `row_alias` syntax added
in MySQL 8.0.19.

There is an ongoing work (vitessio/vitess#15510)
to add that support and it is likely to be included into Vitess v20,
but in the meantime it would be nice to have an ability to control that
behavior in the existing apps.
HeyNonster pushed a commit to HeyNonster/rails that referenced this pull request Jun 12, 2024
@maxprokopiev @HeyNonster
Extract check for VALUES/row_alias syntax
4b5277c 
The change to upserts (rails#51274) is causing
an issue with Vitess, since it doesn't support the `row_alias` syntax added
in MySQL 8.0.19.

There is an ongoing work (vitessio/vitess#15510)
to add that support and it is likely to be included into Vitess v20,
but in the meantime it would be nice to have an ability to control that
behavior in the existing apps.
pjambet pushed a commit to pjambet/rails that referenced this pull request Jul 10, 2024
@maxprokopiev @pjambet
Extract check for VALUES/row_alias syntax
25bc0ea 
The change to upserts (rails#51274) is causing
an issue with Vitess, since it doesn't support the `row_alias` syntax added
in MySQL 8.0.19.

There is an ongoing work (vitessio/vitess#15510)
to add that support and it is likely to be included into Vitess v20,
but in the meantime it would be nice to have an ability to control that
behavior in the existing apps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@frouioui frouioui frouioui approved these changes

@dbussink dbussink dbussink approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@arthurschreiber @dbussink @GuptaManan100 @frouioui